Unit Test this!

dalaohu

to test a very simple method always make me uncertain 'what to test' all the time!

I'd like to know what would you test for method like this one?

public DataSet GetLinksByAnalysisId(int analysisId, IDataAccess _dataAccess)
{
        var result = _dataAccess.SelectAnalysisLinksOverviewByAnalysisId(analysisId);
        return result;
}

[ 本帖最后由 dalaohu 于 2010-4-6 14:33 编辑 ]

dalaohu

start off with my humble one!

[TestMethod]
public void GetLinksById_Should_Return_Links()
{
      var _dataAccess = MockRepository.GenerateMock<IDataAccess>();
      _dataAccess.Expect(x => x.SelectAnalysisLinksOverviewByAnalysisId(0));
      analysisBusinessLogic.GetLinksByAnalysisId(0, _dataAccess);
      _dataAccess.VerifyAllExpectations();
}
===========================================================================

For people that into tests, can you tell me am I testing the right thing? or how would you test it?

[ 本帖最后由 dalaohu 于 2010-4-6 18:01 编辑 ]

wtf

lz 不停的发一些具体的技术贴，让我灰常感动。。

atm

同感动

dalaohu

haha in a good way or bad?

wtf

原帖由 dalaohu 于 2010-4-6 12:27 发表
haha in a good way or bad?

好啊。不过嫩不妨贴点java的东西讨论讨论？

dalaohu

原帖由 wtf 于 2010-4-6 12:32 发表

好啊。不过嫩不妨贴点java的东西讨论讨论？

I try to keep my post as generic as possible. the concept apply exactly same to all OO languages if you using mocks.

中间人

I don't think the method GetLinksByAnalysisId need be tested. It could be replaced directly by two sentences below:

DateTime dateExecuted;
result = _dataAccess.SelectAnalysisLinksOverviewByAnalysisId(settings.UserName, analysisId, out dateExecuted);

And you don't even care about the out dateExecuted value.

中间人

就算 GetLinksByAnalysisId 里有其它逻辑代码跟 dateExecuted 和 result 有关，对 GetLinksByAnalysisId 的测试我认为也不需要mock 一个dataAccess了。因为所有测试都应该focus在result上，应该直接mock result 对象，以及做充分的白盒测试。

当然前提是_dataAccess.SelectAnalysisLinksOverviewByAnalysisId方法有它自己的单元测试，它也应该有自己的单元测试。

dalaohu

Let's say it has to be tested for the sake of code coverage.
What would you test?

dalaohu

原帖由 中间人 于 2010-4-6 13:20 发表
就算 GetLinksByAnalysisId 里有其它逻辑代码跟 dateExecuted 和 result 有关，对 GetLinksByAnalysisId 的测试我认为也不需要mock 一个dataAccess了。因为所有测试都应该focus在result上，应该直接mock result 对象 ...

Mock result? You got me confused.  More details pls. Maybe some demo code?

中间人

原帖由 dalaohu 于 2010-4-6 13:22 发表
Let's say it has to be tested for the sake of code coverage.
What would you test?

I will, if I can, overload _dataAccess.SelectAnalysisLinksOverviewByAnalysisId to take only two params (username, id) and replace the method GetLinksByAnalysisId(...) as _dataAccess.SelectAnalysisLinksOverviewByAnalysisId(settings.UserName, analysisId). So no test needed at all.

If I cannot replace it, I will write Assess.IsTrue(true);

中间人

Mock result? You got me confused.  More details pls. Maybe some demo code?

不好意思，我的意思是，如果 GetLinksByAnalysisId 里有其它针对 result 的代码，比如validation等等，那么直接实例化或者mock相应的 result 对象就可以了。这样便于做white box 测试。

比如
Result result = new Result { Name = 'zhong', Text = 'haha' };
//code to test the new result object;

result = new Result { Name = 'jian', Text = 'xixi' };
//code to test the new result object;

中间人

多说一点，这段代码有点像Adapter，可能和Proxy混用的，如果是这样的话，需要测试实例中的 _dataAccess 是否为空

zn7726

没研究过Unit Test, 看不太懂, 尽量崇拜下高人.

dalaohu

Business Logic Layer:
DataSet GetLinksByAnalysisId(Settings settings, int analysisId)

DataAccess Layer:
IDataAccess _dataAccess
------------------------------------------------------------------

IDataAccess has to be mockup cause I'm testing GetLinksByAnalysisId() in the Business Logic layer

the Result if from this mocked dataAccess - dont' think there's anyting to test

I can set a mocked returned value for result.
_dataAccess.Expect(x => x.SelectAnalysisLinksOverviewByAnalysisId(_settings.UserName, 0, out dateExecuted)).Return(whateverdatareturned)


All I can think of to test is to make sure the dataAccess method SelectAnalysisLinksOverviewByAnalysisId() get called.

北风

不要为了test而test

dalaohu

原帖由 北风 于 2010-4-6 14:18 发表
不要为了test而test

yea I like this theory alot, but it's out-of-scope in this discussion :)
in TDD it's the only way to go

[ 本帖最后由 dalaohu 于 2010-4-6 17:36 编辑 ]

dalaohu

thought I might share with you guys. my initial test wasn't too far from being perfect :)

to make it a full cycle here's the test I'm happy with.

[TestMethod]
public void Test()
{
   var id = 1;
   var expectedResult = new DataSet();

   var dataAccess = MockRepository.GenerateMock<IDataAccess>();
   dataAccess.Expect(x => x.SelectAnalysisLinksOverviewByAnalysisId(1)).Return(expectedResult);

   var analysisBusinessLogic = new AnalysisLinksBusinessLogic(dataAccess);
   var result = analysisBusinessLogic.GetLinksByAnalysisId(id);
   Assert.AreEqual(expectedResult, result);
   dataAccess.VerifyAllExpectations();

}

[ 本帖最后由 dalaohu 于 2010-4-7 19:47 编辑 ]